> On Jan. 11, 2012, 1:29 p.m., Aaron J. Seigo wrote: > > tiny ws issue, but otherwise ok. > > > > and why containment starts from 0 -> because that's where counting starts. > > that virtual desktops in KWindowSystem start at '1' is pretty silly, > > really. otherwise we end up with everything else being zeroth counted as > > per usual, except desktops which are counted from 1. i chose not to extend > > that oddity into plasma code.
thanks for the info. Maybe we should put that on a TODO list for frameworks 5 to change it to start at 0 like it is with NETWM anyway. I guess that it started with 1 in KDE before NETWM had been introduced? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9744 ----------------------------------------------------------- On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103645/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2012, 9:11 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > From Kickoff using "Add to desktop" when you have several virtual desktops > and you enable "Different widgets for each desktop" in the pager settings. > KWindowSystem starts counting from 1 and Plasma from 0 > > Without this fix "Add to desktop" adds to the next desktop or does not add if > you're on the last desktop. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=290368. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368 > > > Diffs > ----- > > plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903 > > Diff: http://git.reviewboard.kde.org/r/103645/diff/diff > > > Testing > ------- > > Local tests as thorough as I could do. > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
