----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103831/#review10264 -----------------------------------------------------------
Ship it! plasma/widgets/iconwidget.cpp <http://git.reviewboard.kde.org/r/103831/#comment8446> this comment is misleading: in libplasma we do not care about "applets in panels". what matters is that someone is listening to the signal for clicked() which means that we have a specific use case that needs to be fulfilled. - Aaron J. Seigo On Jan. 31, 2012, 4:41 p.m., Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103831/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2012, 4:41 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > Same as https://git.reviewboard.kde.org/r/103679/, but for the > Plasma::IconWidget. Let the icon shrink on the double-click event, ignoring > single-clicks, if KDE is set to double-click. Also take in account the corner > case when the IconWidget lives in a panel and thus reacts to the clicked() > signal. > > > Diffs > ----- > > plasma/widgets/iconwidget.cpp 1161cc4 > > Diff: http://git.reviewboard.kde.org/r/103831/diff/diff > > > Testing > ------- > > Tested on desktop and in the panel with KDE set to both double- and > single-click, works fine. > > > Thanks, > > Ignat Semenov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel