----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104396/#review11809 -----------------------------------------------------------
Ship it! Ship It! - Fredrik Höglund On March 24, 2012, 12:42 p.m., Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104396/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 12:42 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Fredrik Höglund. > > > Description > ------- > > Wehn dragging a rubberband over an icon view with a scrollbar, scroll the > view automatically on touching the border with the mouse during drag. > > I've had to mod stopAutoScrolling() and call it in IconView::wheelEvent() and > AbstractItemView::scrollBarActionTriggered() to allow the user to stop the > automatic scrolling on those events. > > > This addresses bug 189350. > http://bugs.kde.org/show_bug.cgi?id=189350 > > > Diffs > ----- > > plasma/applets/folderview/abstractitemview.cpp 3debb70 > plasma/applets/folderview/iconview.h 0bd6dc0 > plasma/applets/folderview/iconview.cpp 36e640b > > Diff: http://git.reviewboard.kde.org/r/104396/diff/ > > > Testing > ------- > > Tested, works. > > Maybe we should also stop automatic scrolling if the user releases the LMB > while scrollling automatically as a result of dragging the rubberband over > the view border? Fredrik, what do you think? > > > Thanks, > > Ignat Semenov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
