> On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote: > > publisher/publisher.cpp, line 132 > > <http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line132> > > > > looks like a stray change... (though signign could be fixed to signing > > ;) > > Giorgos Tsiapaliwkas wrote: > signing doesn't work? I have to investigate it. I should open another > review. Yes?
Aaron was refering to a typo in that comment "signign" vs. "signing". That's all. > On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote: > > publisher/publisher.cpp, line 185 > > <http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line185> > > > > QDir has a cd(const QString &) method that is what you are looking for > > Giorgos Tsiapaliwkas wrote: > I played with QDir::cd but it wasn't working. KProcess wasn't aware of > the QDir::cd so > I used, KProcess::setWorkingDirectory. In my patch I don't like the fact > that I use qgetenv it should be > replaced with something else.Do you agree? > > Also the cmake install works correctly now Seems good enough, let's get this patch in and move on to other things :) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/#review14046 ----------------------------------------------------------- On May 23, 2012, 6:25 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104969/ > ----------------------------------------------------------- > > (Updated May 23, 2012, 6:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > those are some issues which plasmate's publisher has > > problem 1: the publisher's combobox wasn't aware for the right slot. When > currentIndex was emitted both slots(doPlasmaPkg and doCMake was called.) I > fixed that. > problem 2: publisher's cmake process was trying to install a > projectName.plasmoid file and not projectPath/CMakeLists.txt. I fixed that. > problem 3: when the cmake slot is called, cmake creates the known temporary > files in directory like ~/.kde4/share/apps/plasmate/projectName. I haven't > fixed that. > How can I change the current directory with Qt? > > > Diffs > ----- > > publisher/publisher.h 6eba693 > publisher/publisher.cpp 3fcd268 > templates/cmakelists c3e2ce9 > > Diff: http://git.reviewboard.kde.org/r/104969/diff/ > > > Testing > ------- > > WIP > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
