----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105074/#review14535 -----------------------------------------------------------
Ship it! a couple of small items, but looks good to go in. publisher/signingwidget.cpp <http://git.reviewboard.kde.org/r/105074/#comment11490> a more readable, and shorter, idiom is: m_deleteKeyButton->setDisabled(m_noSigningButton->isChecked()); publisher/signingwidget.cpp <http://git.reviewboard.kde.org/r/105074/#comment11491> why is this syncing on every change? seems like a lot of unecessary disk access. publisher/signingwidget.cpp <http://git.reviewboard.kde.org/r/105074/#comment11492> probably not needed :) - Aaron J. Seigo On May 30, 2012, 5:33 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105074/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 5:33 p.m.) > > > Review request for Plasma, Sebastian Kügler and Aaron J. Seigo. > > > Description > ------- > > Hello, > > right now when "Enable signing plasmoid" is enabled if the user doesn't > choose a gpg key, > plasmate won't have a key enabled. So "Enable signing plasmoid", will be > enabled but no signing will > happen. > > How to test the issue, > - rm ${KDEHOME}/share/config/plasmaterc > -create a gpg key(gpg --gen-key) > -open plasmate > -click publisher > -click enable > > > Diffs > ----- > > publisher/signingwidget.h 501752e > publisher/signingwidget.cpp e63dbbd > > Diff: http://git.reviewboard.kde.org/r/105074/diff/ > > > Testing > ------- > > It works. > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
