----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ -----------------------------------------------------------
(Updated June 25, 2012, 12:15 p.m.) Review request for Plasma, KDE Usability and Marco Martin. Changes ------- Updated screenshots to match latest code. Description ------- I made a few changes to make widget explorer nicer in vertical mode - Fix cropped list items. - Make buttons use full width. - Move "Get new widgets" and action buttons to the bottom so that: - different label alignments do not look odd (category button vs others) - category button is closer to the list it controls Additionally it would be much better if tooltips could appear on the right (or left) of the current list item instead of on top of it because it easily gets in the way, but I don't know how to do this. Any idea? An alternative would be to just drop the tooltip, it currently does more harm than good imo. There is also something weird going on with the backgrounds: the "after" screenshots use a opaque background, but that is not part of the patch and I don't understand what makes the code pick the opaque or transparent background. It should be fixed to use the opaque background, again, any idea where that bug could be? Diffs ----- libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegate.qml 68fad80 libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml 4beecec plasma/desktop/shell/activitymanager/package/contents/ui/main.qml 1886529 Diff: http://git.reviewboard.kde.org/r/105329/diff/ Testing ------- - Looks better in vertical mode. - No regression in horizontal mode. Screenshots (updated) ----------- before-after http://git.reviewboard.kde.org/r/105329/s/611/ Thanks, Aurélien Gâteau
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
