> On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: > > Nice catch! > > I do not have a printer that supports reporting ink levels, so I cannot > > test whether it causes unexpected behavior, but I don’t think so. > > Daniel should look over this anyway. > > Thanks for the patch! :)
Sorry, Wrong Review! :D - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 ----------------------------------------------------------- On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105382/ > ----------------------------------------------------------- > > (Updated June 28, 2012, 7:42 p.m.) > > > Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. > > > Description > ------- > > see bug. i guess the window role is the natural and more distinct hint. > > > This addresses bug 302523. > http://bugs.kde.org/show_bug.cgi?id=302523 > > > Diffs > ----- > > kwin/effects/dashboard/dashboard.cpp bb803a9 > plasma/desktop/shell/dashboardview.cpp d6762b6 > > Diff: http://git.reviewboard.kde.org/r/105382/diff/ > > > Testing > ------- > > yes, dashboard still triggers the effect, renamed xterm no longer > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
