> On June 28, 2012, 4:48 p.m., Aaron J. Seigo wrote: > > plasma/desktop/shell/plasmaapp.cpp, line 397 > > <http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397> > > > > i would prefer it if the plugin name and mode were not exposed. the use > > case is "setting a wallpaper image" so let's implement that. > > > > the main problem with being able to set the name and mode is that not > > only are most of the plugins optional (just asking for fun breakage) but > > also require configuration. > > > > so i would recommend a rather simpler setWallpaperImage(const QString > > &url). > > > > it should probably do similar to what the drag and drop support does > > and if the url is not local then try to fetch it using KIO.
Doesn't the Image plugin support fetching url if it is not local ? So it is not needed for this function right ? Also what about exposing the mode also - to be able to change between "SingleImage" and "Slideshow" mode ? Or should we make this just "SingleImage" ? - Varun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/#review15226 ----------------------------------------------------------- On June 24, 2012, 3:47 p.m., Varun Herale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105319/ > ----------------------------------------------------------- > > (Updated June 24, 2012, 3:47 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch is for hosting a dbus-interface that can be used to load any > installed wallpaper plugin onto current desktop containment. In case of > default "image" plugin, the path to the image can also be sent which will > change the wallpaper. > > > Diffs > ----- > > plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 > plasma/desktop/shell/plasmaapp.h 6ae0c89 > plasma/desktop/shell/plasmaapp.cpp 7abd8fc > > Diff: http://git.reviewboard.kde.org/r/105319/diff/ > > > Testing > ------- > > Tested on different activities and made sure it works for per-virtual desktop > containment. > > Haven't tested on a system with multiple screens though, as I don't have > access to one. Could someone please test for that ? > > > Thanks, > > Varun Herale > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
