> On July 16, 2012, 8:30 a.m., Aurélien Gâteau wrote: > > Version 1 was better. The new one produce warnings about binding loops: > > > > QML MouseArea: Binding loop detected for property "acceptedButtons"
Slightly off-topic, but behavior of Plasma Scrollbar component is not really correct: the current behavior reacts to a left-click the way it should react to a middle-click (except it does not correctly center the handle). Your patch makes the scrollbar react to middle-click as expected, which is good (modulo centering of the handle), but reaction to left-click needs more work to be on par with widget-based scrollbars. That is probably out of scope for 4.9, though, and not exactly what the bug report is about. I filed another bug report for it: https://bugs.kde.org/show_bug.cgi?id=303606 - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105576/#review15942 ----------------------------------------------------------- On July 15, 2012, 10:32 p.m., Reza Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105576/ > ----------------------------------------------------------- > > (Updated July 15, 2012, 10:32 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > trying to fix https://bugs.kde.org/show_bug.cgi?id=272934 > by adding mouse middle button click support to scrollbar qml. > > if accepted i will push to KDE/4.9 too. > > > This addresses bug 272934. > http://bugs.kde.org/show_bug.cgi?id=272934 > > > Diffs > ----- > > > plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml > 02a869e > > Diff: http://git.reviewboard.kde.org/r/105576/diff/ > > > Testing > ------- > > tested against widget explorer in master > > > Thanks, > > Reza Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
