----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/#review16574 -----------------------------------------------------------
Ship it! Ship It! - Greg T On July 28, 2012, 1:11 p.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105769/ > ----------------------------------------------------------- > > (Updated July 28, 2012, 1:11 p.m.) > > > Review request for Plasma. > > > Description > ------- > > The cause is simple: two flags m_detailedMenuEntries and > m_detailedEntriesNamesFirst are never explicitly initialized. So their values > are random, and the final results are unpredictable. > > The patch simply initializes both as true, since that seems to be the default > behavior of kickoff. > > > The git history shows those two flags seem to be something left over from the > KDE3 era. Maybe they should just be removed from the code. However, I'm not > familiar with the code and the history, so this simple patch should be safe > choice. > > > This addresses bug 304177. > http://bugs.kde.org/show_bug.cgi?id=304177 > > > Diffs > ----- > > kmenuedit/treeview.cpp 54feff7 > > Diff: http://git.reviewboard.kde.org/r/105769/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
