----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105790/#review17231 -----------------------------------------------------------
If I see it correctly, it is mostly a namespace change (and the old nepomuk namespace is not used anymore), with two other changes so far? If so, I'd rather go for something like namespace Nepomuk = Nepomuk2; and leave the rest of the code as-is. This would remove the necessity to have all these changes again when (in KF5) the namespace is changed again. - Ivan Čukić On July 30, 2012, 12:02 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105790/ > ----------------------------------------------------------- > > (Updated July 30, 2012, 12:02 p.m.) > > > Review request for Plasma and Ivan Čukić. > > > Description > ------- > > this is the diff from master of the branch mart/nepomuk2 in kactivities (the > branch has a more comprehensible history of changes ;). > it ports all the nepomuk usage to nepomuk2 > > > Diffs > ----- > > src/service/CMakeLists.txt f6d7f9c > src/service/NepomukActivityManager.h ba6e75b > src/service/NepomukActivityManager.cpp e06ded3 > src/service/jobs/nepomuk/Move.h 23db0b7 > src/service/jobs/nepomuk/Move.cpp 8342aef > src/service/plugins/sqlite/CMakeLists.txt 1664630 > src/service/plugins/sqlite/NepomukCommon.h c3ecacf > src/workspace/CMakeLists.txt 2fcd194 > src/workspace/kio/CMakeLists.txt 7dfb50c > src/workspace/kio/kio_activities.cpp 8ef1f7b > > Diff: http://git.reviewboard.kde.org/r/105790/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
