----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17282 -----------------------------------------------------------
Thanks for the patch! I'd say that it looks good code-wise (can't say much about the CMake stuff though, my CMake knowledge is rather limited). However, I don't think that we should keep track of the locations that a user visits in a hidden place if the user does not ask for it explicitly (I'm thinking about privacy here). Users know nowadays that they leave lots of traces both on their computer and elsewhere when visiting web pages, but I'm afraid that some users might get upset if they find out that we keep a hidden log of folders that have been opened in Dolphin, considering that Dolphin does currently not have a persistent history of visited folders. But maybe I'm too conservative here, I don't know. Can you provide some information about other info that the activity manager stores without the user's knowledge? Is there a way to disable the logging, and can the user clear the collected data easily? - Frank Reininghaus On Aug. 11, 2012, 10:27 a.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105973/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2012, 10:27 a.m.) > > > Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus. > > > Description > ------- > > Dolphin reports open locations to the activity manager (KAMD). > > Reasoning behind the feature: > - KAMD ranks the locations based on the time the user has spent in them > - Share-Like-Connect applet can know what is open in dolphin > > This is an compile-time-optional feature - turned on if there is > libkactivities installed. > > The find_package(KActivities) is located in the root CMakeLists.txt because > this feature should also be implemented for Konqueror. > > > Diffs > ----- > > dolphin/src/dolphinviewcontainer.cpp 31c82d6 > dolphin/src/dolphinviewcontainer.h fd52806 > CMakeLists.txt fab73c1 > config-apps.h.cmake 43764ef > dolphin/src/CMakeLists.txt 5c1a6da > > Diff: http://git.reviewboard.kde.org/r/105973/diff/ > > > Testing > ------- > > With SDI windows, with tabs. > > > Screenshots > ----------- > > S-L-C showing dolphin folder > http://git.reviewboard.kde.org/r/105973/s/672/ > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
