----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105932/#review17633 -----------------------------------------------------------
this patch does not follow the coding style of the rest of the file (or the rest of the application) has it been tested for all cases where updateStruts is called? does opening the panel editor when there are two panels on the same screen edge result in the panels switching order, for instance? what is the visual cue (if any) nothing what panel the panel controller is associated with when it is shown? why is the panel moved when struts are set? plasma/desktop/shell/panelview.cpp <http://git.reviewboard.kde.org/r/105932/#comment13804> this does not catch CustomPanelContainment - Aaron J. Seigo On Aug. 8, 2012, 4:19 p.m., Tobias Franz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105932/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 4:19 p.m.) > > > Review request for Plasma. > > > Description > ------- > > goes back to: > https://bugs.kde.org/show_bug.cgi?id=165792 > > > This addresses bug 165792. > http://bugs.kde.org/show_bug.cgi?id=165792 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp 50826a8 > > Diff: http://git.reviewboard.kde.org/r/105932/diff/ > > > Testing > ------- > > > Thanks, > > Tobias Franz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
