> On Aug. 23, 2012, 2:53 p.m., Greg T wrote: > > I think this time we can get kickoff-qml into kde 4.10. But this is no > > reason to push this fix not into master :) > > Richard Stockton wrote: > Thanks, Greg! I think we both plan this method for managing the two > modules, please advise if I am no correct: First, right now, this Update goes > to Trunk AND 4.9 because kickoff-widget has not yet been removed from Trunk. > (Trunk shold contain our best code, with all fixes.) When kickoff-qml is > done, and completely replaces kickoff-widget: then it's maintainer should > Update 4.10 branch (if already branched off) AND master, removing > kickoff-widget entirely. That will avoid a 4.10 or later occurence of the bug > which I allowed to re-appear in 4.9, by assuming that kickoff-qml would > replace kickoff-widget within 4.9. > > Removal of Kickoff-widget will be a happy day for everyone - and me, > especially. :)
sounds like a plan :) And your welcome to hack on kickoff-qml as well - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review17903 ----------------------------------------------------------- On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106125/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 12:28 a.m.) > > > Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. > > > Description > ------- > > Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. > This version combines https://git.reviewboard.kde.org/r/104422/ and > https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 > when the feature (RFE bug 276932) is added to 4.9 and Trunk. > > > This addresses bugs 276932 and 297842. > http://bugs.kde.org/show_bug.cgi?id=276932 > http://bugs.kde.org/show_bug.cgi?id=297842 > > > Diffs > ----- > > plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 > plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 > > Diff: http://git.reviewboard.kde.org/r/106125/diff/ > > > Testing > ------- > > #1 Arrow key movement among programs in the flipscrollview (Right, back to > Left, and Up/Down). Activbation of highlighted/selected programs. > #2 Search bar entry, movement into View of matches using the Tab key. Move > among multiple matching prgrams via arrow keys. Tab goes back to the search > TextEdit field, allowing the search to be modified; and it is highlighted, > allowing the search text to be deleted. > #3 an empty search text field re-shows the tab bar and flipscrollview; tab > selection is again enabled via left/right arrow keys. > > NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via > keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller > has insufficient knowledge of where you came from, and often tries to send > your keystroke to an invisible, non-responsive View. IMO, Re-design or total > replacement (Kickoff-QML) IS appropriate. > > But it works.... sort of. > > > Thanks, > > Richard Stockton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
