> On Aug. 26, 2012, 7:50 a.m., Greg T wrote: > > besides the points mentioned in review 106125, you have to remember that > > KDE 4.8 is already EOL and there will be no more bugfix release (i.e. > > 4.8.6). > > Richard Stockton wrote: > Yes, but I was asked to put it on the 4.8 tree in case a packager wants > to pick it up for a Distro patch, e.g. "4.8.5-19". > > Lamarque Vieira Souza wrote: > Well, I do not use 4.8x anymore, this patch does not apply to 4.9 so I > cannot test it. Would you provide a patch for 4.9 branch?
He already did. See review 106125 - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/#review18015 ----------------------------------------------------------- On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106123/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2012, 9:06 p.m.) > > > Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. > > > Description > ------- > > Fix for Kickoff-Widget Keyboard Navigation enhancement (review request > 104422): Following enhancement, when a 'search' is performed, the UI became > unable to move among the views. This patch enables Qt::Key_Tab to (a) enter > into the search Results View, where a program may be selected; (b) move back > into the search bar TextEdit widget, by pressing Key_Tab twice; and (c) > re-expose the other views, by pressing Key_Tab once (highlighting all text > within the seearch bar TextEdit widget), and then pressing Key_Delete to > empty the TextEdit field. When the textEdit is empty, the flipscrollview > (e.g., "Applications") replaces the Search Results View, and the User is back > to the Initial State of the Kickoff-Widget GUI. > > > This addresses bug 297842. > http://bugs.kde.org/show_bug.cgi?id=297842 > > > Diffs > ----- > > plasma/desktop/applets/kickoff/ui/launcher.cpp 902e121 > plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 > > Diff: http://git.reviewboard.kde.org/r/106123/diff/ > > > Testing > ------- > > 1: search with multiple search results: Tab enters the results view, and > arrow keys can choose from multiple results. Key_Enter does run the selected > Application. Per above, Key_Tab returns to the search TextEdit, with existing > contents pre-selected/Highlighted. > 2. search with empty results: arrow keys do nothing. Tab key returns to the > search TextEdit, as in Test #1. > 3. When search TextEdit contains no text (via Key_Delete when highlighted, or > pressing Key_Delete multiple times) the Initial State of the views is > restored: (Tab Bar, Serch Bar, and the selected Tab content present and > executable. > 4. Key_Escape closes the Kickoff UI, without executing a program. > 5. Inability to use Up/Down arrows to go between Views is unfortunate, but > remains unchanged from before. > > > Thanks, > > Richard Stockton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
