> On Sept. 15, 2012, 9:23 a.m., Martin Gräßlin wrote: > > given that everything else uses the optional macro that sounds like a valid > > improvement to me
Great - if nobody objects, I'll push this tomorrow evening. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106444/#review18986 ----------------------------------------------------------- On Sept. 14, 2012, 10:26 a.m., Ralf Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106444/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2012, 10:26 a.m.) > > > Review request for Plasma. > > > Description > ------- > > This makes compilation of KDM optional. KDE works fine without KDM using > another display manager. and considering that even Plasma is optional, I see > no reason for KDM to be mandatory. > > > Diffs > ----- > > CMakeLists.txt 30eb084 > > Diff: http://git.reviewboard.kde.org/r/106444/diff/ > > > Testing > ------- > > Compiled both with default configuration and with BUILD_kdm=Off, verified > that login worked and that the kcm is indeed gone. > > > Thanks, > > Ralf Jung > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
