----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106716/#review19843 -----------------------------------------------------------
thanks for taking care of it ;) almost there, just a couple of things to fix plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h <http://git.reviewboard.kde.org/r/106716/#comment15760> just Prefix of the file path. plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h <http://git.reviewboard.kde.org/r/106716/#comment15758> it will be set for plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h <http://git.reviewboard.kde.org/r/106716/#comment15759> not sure to put this, because it just tells unneeded details about internal implementation plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h <http://git.reviewboard.kde.org/r/106716/#comment15761> basepath/candidate, where candidate is the first one in the list of candidates in order of importance that matches an existing file plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h <http://git.reviewboard.kde.org/r/106716/#comment15762> not quite what it should do, more like: This method resolves a file path based on the base path and the candidates. it searches for a file named key under basepath/candidate/key, and returns the path constructed with the first candidate that matches, if any. @param key the name of the file to search for - Marco Martin On Oct. 3, 2012, 5:15 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106716/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 5:15 p.m.) > > > Review request for Plasma. > > > Description > ------- > > A simple patch which adds a few doxygen comments > > > Diffs > ----- > > plasma/declarativeimports/plasmaextracomponents/fallbackcomponent.h bce15cd > > Diff: http://git.reviewboard.kde.org/r/106716/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
