----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/#review20128 -----------------------------------------------------------
This review has been submitted with commit 7d8cbab9fda4232cbd515fe01f7579d12137a86c by David E. Narváez to branch master. - Commit Hook On Oct. 10, 2012, 1:24 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106622/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 1:24 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Calling setFailedToLaunch removes all child items which causes lots of > trouble down the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706 > > > Diffs > ----- > > applets/microblog/microblog.cpp 376a3cd > > Diff: http://git.reviewboard.kde.org/r/106622/diff/ > > > Testing > ------- > > Assuming you have a microblog plasmoid > > 1. Either remove microblogging library or change the name of the engine in > the code > 2. Restart plasma-desktop > > Before this patch, plasma-desktop would stop loading with SIGSEGV. With this > patch, the plasmoid loads without functionallity and with a label saying it > failed to load the engine. > > > Thanks, > > David Narváez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
