----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ -----------------------------------------------------------
(Updated Oct. 20, 2012, 8:41 a.m.) Review request for Plasma and Martin Gräßlin. Changes ------- yay! simpleapplet working again, thanks Marco and kickoff-qml is now a hybrid c++/qml plasmoid Description ------- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher "simpleapplet"...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs (updated) ----- plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068143d84f9e25dedc8 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f492eb94bf489d87314e1 plasma/desktop/applets/kickoff/applet/plasma-applet-launcher.desktop 8cd616016f858a511c749db28870c3acfcb8a745 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415d64204c795075e16c23e883c plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f42ed57c7c9a6668d5d53b plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2 plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff84bfff65d48bec336afbd plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml PRE-CREATION plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.h PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.cpp PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 7d2fb7bd0d92c8dcaa31a87ca3fcd0742310e101 plasma/desktop/applets/kickoff/simpleapplet/plasma-applet-simplelauncher.desktop 8d3cc0cb28673374ee7e0d46a894605c4f74a9a3 plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18a1cddbd9be58991b35dba69fb60e4416c plasma/desktop/applets/kickoff/ui/brandingbutton.h 698b34e50372dddc3db9425ab2ac639cf90d49b7 plasma/desktop/applets/kickoff/ui/brandingbutton.cpp 5cd8829b8a6cae1e07cbf9bffd3abe77b7f9104e plasma/desktop/applets/kickoff/ui/contentareacap.h 58b37ec74834eefd969786ec99a5cf25b27baf5c plasma/desktop/applets/kickoff/ui/contentareacap.cpp 45e0e2052720402451ae00bed05f6bb0598ec0b3 plasma/desktop/applets/kickoff/ui/contextmenufactory.h a4c3017b537aa12369b08f7fffb28addcca6bce4 plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp afa666ac8dfaf6c746d165d7d662fab185af4442 plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9ccfe07c97208d445f46dcea83bb71207f4 plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd32ba902152a115eea32b8aa3232fe861b plasma/desktop/applets/kickoff/ui/itemdelegate.h bf79e2cc1f501e7136decfa7cd05ea651b109cf6 plasma/desktop/applets/kickoff/ui/itemdelegate.cpp 3b15dd2e7a6ceaba66e1e7da27a811ea8ec31c2f plasma/desktop/applets/kickoff/ui/launcher.h 0c3c5c8d9ec4c49c425763ab1384f7e40e0d57d1 plasma/desktop/applets/kickoff/ui/launcher.cpp 3d8568832626b84441b4eed903c22bdb132e3202 plasma/desktop/applets/kickoff/ui/searchbar.h 60aa9b4b3faaafd5484a36a819b8ac0ed5683a9a plasma/desktop/applets/kickoff/ui/searchbar.cpp ab47302297165bddb68a2732574a2d4acead8e01 plasma/desktop/applets/kickoff/ui/tabbar.h c9281059d35255902fd6d3ed91c5171a44421a51 plasma/desktop/applets/kickoff/ui/tabbar.cpp 43fe16b723ab2010bd02864a911d2d2c8d106821 plasma/desktop/applets/kickoff/ui/urlitemview.h 285227a40b71065a0219c33293c955df3c5c518b plasma/desktop/applets/kickoff/ui/urlitemview.cpp 892b85be96695d7d71d4494af92dae794cb86d66 plasma/generic/dataengines/packagekit/CMakeLists.txt PRE-CREATION plasma/generic/dataengines/packagekit/packagekit.operations PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing ------- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
