----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106978/#review20642 -----------------------------------------------------------
There does not seem to be a diff attached. - David Edmundson On Oct. 21, 2012, 3:43 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106978/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2012, 3:43 p.m.) > > > Review request for Plasma. > > > Description > ------- > > The main issue was caused by the fact that asking the tab bar native widget > to provide a size hint was giving a different size every time which caused > the activity bar to expand or shrink in the presence of another expanding > widget (in my case, the taskbar), so this patch decides a size hint from the > size of the containment (one third of the width of height depending on the > form factor) but the size policy is set to expand when the activity bar is > the only widget in the containment. > > > This addresses bug 225078. > http://bugs.kde.org/show_bug.cgi?id=225078 > > > Diffs > ----- > > > Diff: http://git.reviewboard.kde.org/r/106978/diff/ > > > Testing > ------- > > 1) Add a panel with an actyivity bar and a task bar > 2) Add a panel with an activty bar only > 3) Change activities > > Before this patch, the activity bar in the panel with a task bar shrinks or > enlarges with every activity change; while the size of the activity bar in > the second panel remains constant. After this patch, the size of the activity > bar in both panels remains constant. > > > Thanks, > > David Narváez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
