> On Nov. 6, 2012, 5:53 p.m., Daker Pinheiro wrote: > > You should move the javascript functions to a separated Javascript file. > > It would keep the plasmoid modularized. > > A repeater could be used for creating the digits button.
>You should move the javascript functions to a separated Javascript file. See above response to Mark. - Romário ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21493 ----------------------------------------------------------- On Nov. 6, 2012, 2:54 a.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107001/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 2:54 a.m.) > > > Review request for Plasma. > > > Description > ------- > > This diff replaces the C++ Calculator applet by its QMLfied version, which > seems to be feature-par with the latter. > > > Diffs > ----- > > applets/calculator/CMakeLists.txt 732145c > applets/calculator/calculator.h f7339be > applets/calculator/calculator.cpp 6bc3ddc > applets/calculator/package/contents/ui/calculator.qml PRE-CREATION > applets/calculator/package/metadata.desktop PRE-CREATION > applets/calculator/plasma-applet-calculator.desktop 0760729 > > Diff: http://git.reviewboard.kde.org/r/107001/diff/ > > > Testing > ------- > > Tested as both applet and popupapplet, with the Air theme and the Oxygen > theme. It seems to work fine. > > > Thanks, > > Romário Rios > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel