> On Nov. 26, 2012, 1:43 p.m., Diego Casella wrote: > > plasmate/CMakeLists.txt, line 102 > > <http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102> > > > > I'm wondering if we really need to add a kdepimutils dependency for a > > simple email validation... Thoughts about that? > > > > In any case, "kpimutils" must be discarded and substituted with the > > more portable ${KDEPIMLIBS_KPIMUTILS_LIBS} (more info inside > > FindKdepimLibs.cmake file). > > Giorgos Tsiapaliokas wrote: > >I'm wondering if we really need to add a kdepimutils dependency for a > simple email validation... Thoughts about that? > Plasmate already depends on qgpgme++ library which is in kdepimlibs. > Kdepimutils are also part of the kdepimlibs. > So we don't introduce a new depedency for a new repository. > > Also we have been advised for this change from the kdereview.
As regards your 2nd statement, KPIMUtils::isValidSimpleAddress doesn't have a correct api, so that was the best thing that i found. But yes, that could be changed. Now as regards the depedency, i agree, that we don't really need that library. But the people on kcd, said that we should replace it. - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22561 ----------------------------------------------------------- On Nov. 26, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107470/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 10:36 a.m.) > > > Review request for Plasma. > > > Description > ------- > > On this patch i am replace the QRegExp on SigningDialog::validateParams() > with KPIMUtils::isValidSimpleAddress > > > Diffs > ----- > > plasmate/CMakeLists.txt 111c402 > plasmate/publisher/signingdialog.cpp 395138d > > Diff: http://git.reviewboard.kde.org/r/107470/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
