----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106582/#review22760 -----------------------------------------------------------
This review has been submitted with commit 3eff802699ab328af27c5269d4284e2997d9bab4 by Giorgos Tsiapaliokas to branch master. - Commit Hook On Nov. 26, 2012, 2:45 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106582/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 2:45 p.m.) > > > Review request for Plasma. > > > Description > ------- > > I have populated the settings of the rssnow-qml plasmoid > and they are identical to the ones of the c++ one. > > In order to do that I made the rssnow-qml plasmoid into a hybrid. > > After submit of this review I believe that it is ready to be > moved into the kdeplasma-addons and to remove the c++ one. > (I would prefer to open a new review for the move) > > Also I have pushed the latest changes(this diff) into the > terietor/rssnow/settings branch in declarative-plasmoids > > > Diffs > ----- > > rssnow/CMakeLists.txt 79b3581 > rssnow/feedsConfig.ui PRE-CREATION > rssnow/generalConfig.ui PRE-CREATION > rssnow/package/contents/config/main.xml e05fcbf > rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION > rssnow/package/contents/ui/ListItemEntry.qml 657b14b > rssnow/package/contents/ui/config.ui e1e3409 > rssnow/package/contents/ui/main.qml a575c29 > rssnow/package/metadata.desktop ef72f15 > rssnow/plasma-applet-rssnow-qml.desktop ef72f15 > rssnow/plasma-applet-rssnow.desktop PRE-CREATION > rssnow/rssnow.h PRE-CREATION > rssnow/rssnow.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106582/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
