> On Nov. 29, 2012, 1:53 p.m., Aaron J. Seigo wrote: > > plasmate/packagemodel.cpp, lines 196-205 > > <http://git.reviewboard.kde.org/r/106680/diff/5/?file=93807#file93807line196> > > > > why not add "images", "config" and "animations" to > > m_themeImageDialogOptions and rename it to m_dialogOptions
I have put "images" and "config" into the hash, but how can it be done for "animations" too? > else if(!qstrcmp(key, "animations") && packageType() != "Plasma/Theme") we check the key and the packageType, so we can't use the hash here. No? > On Nov. 29, 2012, 1:53 p.m., Aaron J. Seigo wrote: > > plasmate/packagemodel.cpp, line 544 > > <http://git.reviewboard.kde.org/r/106680/diff/5/?file=93807#file93807line544> > > > > "Plasma/Theme" should not appear in this file. the "colors" file isn't a requiredDirectory nor a requiredFile, so If I don't add it by hand in the m_topEntries it won't be visible and also we want the "colors" file in the m_topEntries only when the package is a theme. No? What am I missing? - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review22754 ----------------------------------------------------------- On Nov. 5, 2012, 5:51 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106680/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2012, 5:51 p.m.) > > > Review request for Plasma. > > > Description > ------- > > create a new theme package->click on the new > > a file dialog should appear but instead a simple edit box appears requesting > a new filename. > > This patch solves the issue > > > Diffs > ----- > > plasmate/editors/editpage.h 5cb3ea6 > plasmate/editors/editpage.cpp 7e82ff2 > plasmate/packagemodel.h efa3001 > plasmate/packagemodel.cpp 9eb0914 > > Diff: http://git.reviewboard.kde.org/r/106680/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
