----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review25666 -----------------------------------------------------------
No problem for the effects, but insufficient for the tabbox because of eg. the requirement to mask the window (no idea whether that works at all) and doesn't catch plasma dialogs etc. - yet (aside the margin issue) better that what is there and the fix in the shadow frame is pretty much required. - Thomas Lübking On Jan. 16, 2013, 1:57 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108438/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 1:57 p.m.) > > > Review request for kwin, Plasma, Sebastian Kügler, and Xuetian Weng. > > > Description > ------- > > Use translucent/dialogs/background elements where possible > > In effects it's obvious that compositing is enabled, so specifying the > translucent element is no problem. > > In tabbox a context property "compositing" is injected which decides > whether "translucent" or "opaque" elements should be used. > > Also the masking is adjusted to ensure that only the shadow is not > blurred. > > Reason for this change is that Plasma theme seems not always to pick up > whether compositing is used when used from inside KWin. It does not cover > the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot > (yet) inject that we use compositing. > > CCBUG: 311995 > > > Diffs > ----- > > kwin/effects/desktopgrid/desktopgrid.cpp > 53532ccff72d2a1f303265a898fd7b1fc7ea35a6 > kwin/effects/presentwindows/presentwindows.cpp > 100d5ec0ab80b50d8b3d0b68d11bc08f55da15ca > kwin/tabbox/declarative.cpp b4d615178a0e0b8b633626a1813dfa7065515b97 > kwin/tabbox/qml/CMakeLists.txt bda7d8b95ed3b4fb4093c9960f940a0d678710f8 > kwin/tabbox/qml/ShadowedSvgItem.qml > 87de733bf0fa1ad19d4d9203de6c6fc3548ff57f > kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml > 4a3666d2befe0010f7d9b7d4414853e8c92a92a1 > kwin/tabbox/qml/clients/compact/contents/ui/main.qml > 14fca297c40a8338de1fff413f7e4b5b0a4aef45 > kwin/tabbox/qml/clients/informative/contents/ui/main.qml > 5e3f9a6f2ad76e7eeb7ee1e51d42e0c891b762ec > kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml > e539c8970acff701b92bdaaf816a40ccba94e4b8 > kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml > 0c9b4f7f7df52f8a629d0c847185db38aa9f2c26 > kwin/tabbox/qml/clients/text/contents/ui/main.qml > ccae17d96b231269a7d8ec0ecc20b0ee69453d09 > kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml > 4c33703d54c84fd54da94f821234e4cbd9c1c001 > kwin/tabbox/qml/desktop.qml e8203b6004a321fcc5ae6d10347fdbb7144662a7 > > Diff: http://git.reviewboard.kde.org/r/108438/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
