-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109859/#review30809
-----------------------------------------------------------


This review has been submitted with commit 
b32e6a8ebbebb6dfa836712874d942133a0fff71 by Alex Merry to branch master.

- Commit Hook


On April 4, 2013, 5:14 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109859/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 5:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds an extra step to the lookup of SVG images created with the Svg() 
> global function: after looking in images/ in the plasmoid and then in the 
> desktop theme, it looks in theme/$DESKTOP_THEME_NAME and then theme/ in the 
> plasmoid.
>     
> This allows plasmoid authors to add images that they want to allow theme 
> authors to override.
> 
> Depends on RR 109857
> 
> 
> Diffs
> -----
> 
>   plasma/scriptengines/javascript/plasmoid/themedsvg.cpp 
> 9de25a1bad3380ac964685b0516705d906a10592 
> 
> Diff: http://git.reviewboard.kde.org/r/109859/diff/
> 
> 
> Testing
> -------
> 
> Checked with Now Playing that Svg("nocover") finds 
> "content/images/nocover.svgz" and "content/theme/nocover.svgz" in the 
> plasmoid, and that $KDEDIR/share/apps/desktoptheme/default/nocover.svgz 
> overrides the latter.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to