----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110290/#review31983 -----------------------------------------------------------
Ship it! Some small niggles, looks pretty good already. Please change those, then it's good to go into master. plasma/generic/dataengines/share/backends/im9/CMakeLists.txt <http://git.reviewboard.kde.org/r/110290/#comment23825> install the directory, not the individual files. That way, when someone adds a file (for example by splitting out something from main.js), the CMakeLists.txt files doesn't need adjustment. It's also more in line with how we do it in the rest of Plasma. plasma/generic/dataengines/share/backends/im9/contents/code/main.js <http://git.reviewboard.kde.org/r/110290/#comment23826> stray whitespace - remove it - Sebastian Kügler On May 3, 2013, 8:48 p.m., Michał Dutkiewicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110290/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 8:48 p.m.) > > > Review request for Plasma, Aaron J. Seigo, Artur Duque de Souza, and Marco > Martin. > > > Description > ------- > > This patch adds support for im9.eu images upload service to share data engine. > > > Diffs > ----- > > plasma/generic/dataengines/share/backends/CMakeLists.txt 30695d3 > plasma/generic/dataengines/share/backends/im9/CMakeLists.txt PRE-CREATION > plasma/generic/dataengines/share/backends/im9/contents/code/main.js > PRE-CREATION > plasma/generic/dataengines/share/backends/im9/metadata.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110290/diff/ > > > Testing > ------- > > Tested with KDE 4.10, works fine. > > > Thanks, > > Michał Dutkiewicz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
