Ok I will commit it. About the comment, if you go by that reasoning, the code will become full of unnecessary comments. So unless absolutely necessary, you don't want to do that. If someone wants it back, there is git ;)
On Thu, May 16, 2013 at 10:52 PM, Akshay Ratan <akshayra...@gmail.com>wrote: > Hi, > Yes I think it would be perfect if you commit it for me. I dont yet > have KDE Developers Right. > > Also, my reason for commenting the line was if in future somebody wants to > code some added feature regarding the playlist, the line might be of some > help. Anyways, should I remove it if you say ? > > Cheers, > Akshay Ratan > > On Thu, May 16, 2013 at 10:45 PM, Shantanu Tushar <shant...@kde.org>wrote: > >> This is an automatically generated e-mail. To reply, visit: >> http://git.reviewboard.kde.org/r/110475/ >> >> Ship it! >> >> Looks good. Should I commit this for you? >> >> >> >> mediaelements/playlist/PlaylistDelegate.qml<http://git.reviewboard.kde.org/r/110475/diff/1/?file=144360#file144360line59> >> (Diff >> revision 1) 58 >> >> visible: listViewItem.ListView.isCurrentItem >> >> 59 >> >> // visible: listViewItem.ListView.isCurrentItem >> >> don't use comments, just remove the line >> >> >> - Shantanu >> >> On May 16th, 2013, 5:07 p.m. UTC, Akshay Ratan wrote: >> Review request for Plasma, Marco Martin, Shantanu Tushar, and Sinny >> Kumari. >> By Akshay Ratan. >> >> *Updated May 16, 2013, 5:07 p.m.* >> Description >> >> Fixed bug 319626 ( https://bugs.kde.org/show_bug.cgi?id=319626) . Now, in >> the media playlist, "remove" sign is shown on every song , so the user has >> to just click that "sign" instead of clicking the song which earlier stopped >> the media. >> >> So basically now the current media is not stopped when deleting an item from >> a playlist. >> >> >> Testing >> >> Yes >> >> *Bugs: * >> https://bugs.kde.org/show_bug.cgi?id=319626<http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=319626> >> Diffs >> >> - mediaelements/playlist/PlaylistDelegate.qml (449a0aa) >> >> View Diff <http://git.reviewboard.kde.org/r/110475/diff/> >> >> _______________________________________________ >> Plasma-devel mailing list >> Plasma-devel@kde.org >> https://mail.kde.org/mailman/listinfo/plasma-devel >> >> > > > -- > Akshay > -- Shantanu Tushar (UTC +0530) http://www.shantanutushar.com
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
