----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110761/#review33555 -----------------------------------------------------------
Ship it! Ship It! - Aaron J. Seigo On June 1, 2013, 12:05 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110761/ > ----------------------------------------------------------- > > (Updated June 1, 2013, 12:05 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Fix behaviour in DialogProxy::setAttribute > > Only call KWindowSystem::setOnAllDesktops when we enable WindowTypeDock > and only remove KWindowSystem::setOnAllDesktops when we disable WindowTypeDock > not when we set any other attribute (which is what previous code does) > > --- > > Old code looked wrong, I was hunting down a different bug when I noticed it. > > In reality despite being "wrong", it doesn't seem to have caused any problems > so far as the only usage seems to be the notification plasmoid which simply > calls setAttribute(Qt.WA_X11NetWmWindowTypeDock, true) once. > > > Diffs > ----- > > plasma/declarativeimports/core/dialog.cpp > b19ff5b8c576d18646f4d62c8ee35ca91f1dd17d > > Diff: http://git.reviewboard.kde.org/r/110761/diff/ > > > Testing > ------- > > Notification plasmoid behaved exactly the same as before. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
