----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111087/#review34596 -----------------------------------------------------------
Both the old as well as the new code look wrong. Vertical text alignment should be done using the font's natural box (fm.height()), not the bounding boxes of certain characters. - Christoph Feck On June 18, 2013, 11:44 a.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111087/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 11:44 a.m.) > > > Review request for Plasma. > > > Description > ------- > > welcome to the taskbar bug marathon ;) > > this change corrects the issue reported in the report. the diff is trivial > (though I think the tasklabel code is silly and too complex) but I'm not sure > if I can approve the aesthetic consequences (see screenshot): the text moves > slightly to the top of the label area, but imho relative to the vertically > centered icon widget it looks misplaced. > > What do you think? > > > This addresses bug 314879. > http://bugs.kde.org/show_bug.cgi?id=314879 > > > Diffs > ----- > > plasma/desktop/applets/tasks/support/textlabel.cpp > 9fbc12d621c2917665fb963c0087f3a59c9e86e9 > > Diff: http://git.reviewboard.kde.org/r/111087/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
