----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/#review36732 -----------------------------------------------------------
Ship it! other than the args member in the private class which should be removed, this is good to go imho src/plasma/dataengine.cpp <http://git.reviewboard.kde.org/r/111691/#comment27128> args aren't used here; may as well remove it src/plasma/private/dataengine_p.h <http://git.reviewboard.kde.org/r/111691/#comment27129> see above - Aaron J. Seigo On July 28, 2013, 11:24 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111691/ > ----------------------------------------------------------- > > (Updated July 28, 2013, 11:24 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > This adds back a ctor that is useful for creating a KPluginFactory, which has > the metadata baked into the plugin. With corresponding patches to kdelibs, > this allows to create a dataengine, with valid KPluginInfo from a Qt plugin > (i.e. without using KService) > > > Diffs > ----- > > src/plasma/dataengine.h d3baad3 > src/plasma/dataengine.cpp a2c68cb > src/plasma/private/dataengine_p.h d8ade83 > > Diff: http://git.reviewboard.kde.org/r/111691/diff/ > > > Testing > ------- > > Build and loaded plugin, verified metadata is completely inside KPluginInfo > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
