> On Aug. 27, 2013, 10:57 a.m., Martin Klapetek wrote: > > File Attachment: Control Icon and Label left aligned > > <http://git.reviewboard.kde.org/r/112208/#fcomment86> > > > > I wonder if we still need the speaker icons. The way I see it they > > represent two things - one is "how loud is this sound" (higher the volume > > is, more arcs the icon has). This is also represented by the slider and > > then by the percentage string too, so the "volume" information is there 3 > > times. The second thing it does is saying "this is a volume control". This > > on the other hand is quite important I think, although if you popup kmix > > applet (which has the speaker icon again), I guess one expects the sliders > > to be volume adjusting sliders. Dunno, I think the plasmoid would be > > clearer without the speaker icons. > > > > Either way, looks good when left aligned, good job!
That is a plain Plasma ToolButton, not a simple icon, which does the same as the button you can find in the "old" KMix interface does. If you click it, the corresponding channel will be muted. If it's already muted, it will be un-muted :) imho the label gives a more concise/precise info about the actual volume level, which the slider cannot offer because of its nature. - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review38727 ----------------------------------------------------------- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112208/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 8:40 a.m.) > > > Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and > Igor Poboiko. > > > Description > ------- > > KMix qml applet. > As you can see from the screenshot, the applet is pretty much functional: you > can display all the controls available, change its orientation, and decide to > whether show all of them or just the Master Control, and refresh its status > when new controls are added/removed/updated (such as Amarok current playing > track). See screenshots below :) > Differences from the old kmix tray: > * no media player controls ( I never investigated how to get them, but > honestly opening the audio applet to change/skip/pause audio track makes > little sense to me ... if anyone wants this feature back, don't be shy and > step in); > * the button used to select which Mixers are visible has been changed to open > Phonon kcm page: since visible mixers are already configurable from KMix app, > having a button to show KMix *and* a button to modify Mixers visibilty made > little sense here too, so I preferred to give more visibility to Phonon kcm; > > Known issues: > * there is still no way to get notified of mouse wheel events over the > popupIcon, so it is not possible to scroll over to increase/decrease the > master control volume; > * no scroll events over the sliders too; > * if you want to use the applet you most likely will disable KMix tray icon > but, if you do so, KMix will show its GUI at every login and you have to > close it manually. This requires KMix to be patched. Furthermore, if you > click "KMix Setup" button, KMix window will not restored anymore: this needs > to be pathed as well. > * resize doesn't work properly. > > > Diffs > ----- > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml > PRE-CREATION > plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112208/diff/ > > > Testing > ------- > > Tested against master and works fine. > > > File Attachments > ---------------- > > Default look > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png > Menu Actions > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png > Applet Config Options > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png > Vertical Control > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png > ToolButton label and Config page after updates > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png > Control Icon and Label left aligned > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
