> On Sept. 7, 2013, 7:40 a.m., Hugo Pereira Da Costa wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 619 > > <http://git.reviewboard.kde.org/r/112375/diff/5/?file=187729#file187729line619> > > > > These changes (612 to 619) are unrelated. Right ? This is just coding > > style. > > I guess I'm ok with it, but I might change it back in the future to the > > (somewhat personal, I agree) coding style of the rest of the file
Edited, left them unchanged. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review39515 ----------------------------------------------------------- On Sept. 7, 2013, 1:14 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112375/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2013, 1:14 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Description > ------- > > Correctly determine frame width when called from QtQuickControls > > When oxygen is used in QtQuickControls the widget parameter is empty > as such we need to determine the widget type (lineedit etc. ) in a > different way > > > Diffs > ----- > > kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 > > Diff: http://git.reviewboard.kde.org/r/112375/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > QML After > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png > QML_Before > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png > Normal oxygen demo > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
