----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113078/#review41202 -----------------------------------------------------------
this review is less about the actual code in this review and more about the design of the system monitor in general. currently the main applet embeds the other applets; this obviously won't work in the QML2 world. so each of the small applets really needs to become an individual QML item that can be re-used in both individual applets and in combination with each other. to that end, my proposal is this: * create a QML import that contains all of the monitors as individual QML items. * create a stand-alone plasmoid that wraps those monitors * design a way to allow the kind of scripting/control that we see in popular packages like conkie to allow re-use of these components; perhaps the best way to do this would be to provide a small designer tool that would let one define the order of components and what they should be showing which would then export a finished plasmoid implementing that design. - Aaron J. Seigo On Oct. 3, 2013, 4:03 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113078/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 4:03 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > start porting system monitor applet, step 1 hwinfo applet > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt 2e9a390 > plasma/generic/applets/system-monitor/CMakeLists.txt 002e1db > plasma/generic/applets/system-monitor/hwinfo/contents/ui/main.qml > PRE-CREATION > plasma/generic/applets/system-monitor/hwinfo/metadata.desktop PRE-CREATION > plasma/generic/applets/system-monitor/plasma-applet-sm_hwinfo.desktop > aa31f89 > > Diff: http://git.reviewboard.kde.org/r/113078/diff/ > > > Testing > ------- > > works as expected.. requires bit UI change. > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
