> On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: > > src/plasma/CMakeLists.txt, line 173 > > <http://git.reviewboard.kde.org/r/113139/diff/1/?file=199605#file199605line173> > > > > The if-else shouldn't be needed. INSTALL_INTERFACE should already check > > if ${INCLUDE_INSTALL_DIR} is absolute. > > Ben Cooksley wrote: > I copied this code from KCoreAddons in kdelibs[frameworks]. Shall I > correct it there as well?
It appears in several other frameworks too. Actually your snippet is needed until CMake 2.8.12. I'll remove it from them all when kde requires that version. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/#review41324 ----------------------------------------------------------- On Oct. 7, 2013, 10:48 a.m., Ben Cooksley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113139/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 10:48 a.m.) > > > Review request for kdelibs, Plasma and Stephen Kelly. > > > Repository: plasma-framework > > > Description > ------- > > Add include targets for KF5::plasma, which will hopefully contribute towards > fixing the kde-workspace[master] build on build.kde.org. > Unfortunately it isn't entirely successful as it seems camelcase headers are > installed by KF5::plasma into include/KDE/Plasma/ but it should be a start... > > > Diffs > ----- > > src/plasma/CMakeLists.txt b21fd7b > > Diff: http://git.reviewboard.kde.org/r/113139/diff/ > > > Testing > ------- > > In place on CI build system. Proper include path now given to compiler. > > > Thanks, > > Ben Cooksley > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
