----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113362/#review42091 -----------------------------------------------------------
Could you make it conditional, that should be easy enough for this case, we can always make it non-optional later. It should also help us keeping the build intact until everybody has installed a working KActivities. If you're looking for an example how to do that, the statusnotifier engine is also optional. Otherwise, changes look good. plasma/generic/dataengines/activities/activityjob.cpp <http://git.reviewboard.kde.org/r/113362/#comment30679> This can just go away. - Sebastian Kügler On Oct. 21, 2013, 11:25 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113362/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 11:25 a.m.) > > > Review request for Plasma, Ivan Čukić and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > Port KActivity DataEngine to KF5 > > follow ups: > > * Activitybar > * Show activity-manager > * Activity manger (In progress, Since Declarative widgets are gone, > converting wrapper to private import, will be moved to plasma-framework(?)) > > Commented out setActivityEncrypted() call because not sure if it is gone or > will come back.. > > Also this commit can break build on Jenkins(?).. > > I made this adjustments before KActivity cmake thing. > > > Diffs > ----- > > CMakeLists.txt 57263a3 > plasma/generic/dataengines/CMakeLists.txt 7826422 > plasma/generic/dataengines/activities/CMakeLists.txt aa3b607 > plasma/generic/dataengines/activities/activityengine.cpp cf73d85 > plasma/generic/dataengines/activities/activityjob.cpp 1a463e2 > > Diff: http://git.reviewboard.kde.org/r/113362/diff/ > > > Testing > ------- > > * Compiles > * Links > * Installs > * Loads in plasmaengineexplorer > * Lists activities and status > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel