> On Oct. 27, 2013, 2:12 a.m., David Edmundson wrote: > > Looks good to me. > > > > FWIW, when you move files it's best if you make diffs with "git diff > > --find-copies-harder" that way reviewboard doesn't show that you deleted > > and created a file. Otherwise I end up commenting on things you didn't > > change. (
Thanks for the tip! :) - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113420/#review42409 ----------------------------------------------------------- On Oct. 24, 2013, 8:39 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113420/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 8:39 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > port activitybar applet to plasma2 > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt f03f941 > plasma/generic/applets/activitybar/CMakeLists.txt 297f1a9 > plasma/generic/applets/activitybar/contents/ui/main.qml PRE-CREATION > plasma/generic/applets/activitybar/metadata.desktop PRE-CREATION > plasma/generic/applets/activitybar/package/contents/ui/main.qml a6d5026 > plasma/generic/applets/activitybar/package/metadata.desktop b1f2ece > > Diff: http://git.reviewboard.kde.org/r/113420/diff/ > > > Testing > ------- > > I don't have any stuffs that can help me to test if it switch activities in > Plasma2 or not. It lists my kde4 activities.. > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
