----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113535/#review42771 -----------------------------------------------------------
Ship it! Looks good to me, approved. - Mirko Boehm On Nov. 1, 2013, 1:31 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113535/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 1:31 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > With recent API updates in ThreadWeaver, "enqueueRaw()" was obsoleted. > According to ThreadWeaver maintainers, the correct way to restart threads is > to call "reschedule()", but I am not sure if my fix is correct, partly > because the comment seems to be in the wrong place. > > > Diffs > ----- > > src/plasma/private/runnerjobs_p.h dfc2aca > src/plasma/runnermanager.cpp ee4851f > > Diff: http://git.reviewboard.kde.org/r/113535/diff/ > > > Testing > ------- > > Compiles, no further testing. > > > Thanks, > > Christoph Feck > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel