> On Nov. 20, 2013, 5:01 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 238 > > <http://git.reviewboard.kde.org/r/113971/diff/1/?file=215038#file215038line238> > > > > this loop is required to make the qml/graphicsscene properly hadnle the > > forwarded events.
instead of putting a comment in the reviewboard entry, how about some comments in the code explaining why this code is necessary? usually if it needs to be explained, then comments in the code are called for. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113971/#review44054 ----------------------------------------------------------- On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113971/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 4:52 p.m.) > > > Review request for Plasma, Christoph Feck and Martin Gräßlin. > > > Bugs: 311188 > http://bugs.kde.org/show_bug.cgi?id=311188 > > > Repository: kde-workspace > > > Description > ------- > > - pass focus to greeter under the mouse > - share keyboard events > - let through keyboard events for one hidden locker > (mouse wakeup case) > - remove double filtering > > @Christoph: > I meant a real human. A shared responsibility simply means that no one is > responsible. > > @Martin: > I found the dupe and it's assigned to you. Do you feel in charge here or do > you know whom to addd? > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeterapp.h 951b1e3 > ksmserver/screenlocker/greeter/greeterapp.cpp bf33945 > > Diff: http://git.reviewboard.kde.org/r/113971/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
