> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at > comment #1 for the "onReleased" function, so it seems there is no other way > to fix it. > > Teemu Rytilahti wrote: > Yup, seems to be the same there, added to the list. > > Christoph Feck wrote: > Teemu, if there are no objections within the next three days, please > commit it to 4.11 branch.
If I understand your recent message on #plasma correctly, you found issues with the current patch. Could you add a comment with your findings, discard the request, or update it with an updated patch? - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/#review43193 ----------------------------------------------------------- On Nov. 7, 2013, 12:27 a.m., Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113697/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 12:27 a.m.) > > > Review request for Plasma. > > > Bugs: 314720, 316084, 319935, and 324821 > http://bugs.kde.org/show_bug.cgi?id=314720 > http://bugs.kde.org/show_bug.cgi?id=316084 > http://bugs.kde.org/show_bug.cgi?id=319935 > http://bugs.kde.org/show_bug.cgi?id=324821 > > > Repository: kde-workspace > > > Description > ------- > > The focus is being stolen from the input field when alt is being pressed in > order to make it possible to use keyboard to do unlocking. Unfortunately this > causes the focus never to be returned to the input field. > > This fixes at least 314720, but perhaps other similar bugs such as 324821 > too. 324821 is also partially related. > > > Diffs > ----- > > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > 66a3bb4 > > Diff: http://git.reviewboard.kde.org/r/113697/diff/ > > > Testing > ------- > > Tested on recent git installation. > > > Thanks, > > Teemu Rytilahti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
