> On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote: > > I've installed the applet, and had a look in more detail. It's coming along > > really nicely, and already feels a lot better than the QWidget-based kmix. > > :) > > > > Some issues I've found: > > - Resizing the popup dialog doesn't resize its content, this leads to > > unfriendly resizing on the one hand, and clipping of the list of channel > > items on the other > > - The listview is draggable when it doesn't have to be, use something like > > interactive: height < contentsHeight in the ListView to prevent that from > > happening > > - The vertical view needs definitely more spacing, if we really want to > > keep it > > - Some spacing would do the listview good, this leads to better grouping of > > the channel items > > - The item name isn't properly anchored and should either determine the > > minimum width, or be elided > > - The percentage on the left hand side should not be bold > > - The slider feels a bit jerky, this is probably the event round-tripping > > Xetuan mentions, see that part of the thread > > - The speaker icon feels a bit weird to mute the channel, I think that's > > because it's used with different semantics for the applet as well: open > > mixer (the panel icon). Maybe it could be done with a checkbox, and > > possibly moved to the top-right, so that the layout > > - The initial values in the config dialog are not set up correctly. Try > > switching to master channel only, OK, reopen config dialog: it's set to > > show all channels. Haven't checked if this is also the case for the > > orientation > > - Show all mixers -> "Show all Channels" (i.e. does "mixer" make sense > > here, or is it really a channel, or a "Volume Control"? > > - "Mixer slider orientation" -> "Orientation" ? > > > > Overall, nice work. This is good stuff. =)
Haven't heard about this in a long time, what's the status? - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/#review39222 ----------------------------------------------------------- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112208/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 8:40 a.m.) > > > Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and > Igor Poboiko. > > > Repository: kmix > > > Description > ------- > > KMix qml applet. > As you can see from the screenshot, the applet is pretty much functional: you > can display all the controls available, change its orientation, and decide to > whether show all of them or just the Master Control, and refresh its status > when new controls are added/removed/updated (such as Amarok current playing > track). See screenshots below :) > Differences from the old kmix tray: > * no media player controls ( I never investigated how to get them, but > honestly opening the audio applet to change/skip/pause audio track makes > little sense to me ... if anyone wants this feature back, don't be shy and > step in); > * the button used to select which Mixers are visible has been changed to open > Phonon kcm page: since visible mixers are already configurable from KMix app, > having a button to show KMix *and* a button to modify Mixers visibilty made > little sense here too, so I preferred to give more visibility to Phonon kcm; > > Known issues: > * there is still no way to get notified of mouse wheel events over the > popupIcon, so it is not possible to scroll over to increase/decrease the > master control volume; > * no scroll events over the sliders too; > * if you want to use the applet you most likely will disable KMix tray icon > but, if you do so, KMix will show its GUI at every login and you have to > close it manually. This requires KMix to be patched. Furthermore, if you > click "KMix Setup" button, KMix window will not restored anymore: this needs > to be pathed as well. > * resize doesn't work properly. > > > Diffs > ----- > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION > plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml > PRE-CREATION > plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112208/diff/ > > > Testing > ------- > > Tested against master and works fine. > > > File Attachments > ---------------- > > Default look > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png > Menu Actions > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png > Applet Config Options > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png > Vertical Control > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png > ToolButton label and Config page after updates > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png > Control Icon and Label left aligned > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
