----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/ -----------------------------------------------------------
(Updated Dec. 31, 2013, 3:06 a.m.) Review request for Plasma. Changes ------- whitespace Bugs: 321803 http://bugs.kde.org/show_bug.cgi?id=321803 Repository: kde-workspace Description ------- The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters. Instead of increasing regexp complexity, I simply use the QChar category functions to check for letters. Additionally, any input non consisting of at least a single digit requires the leading or trailing '=' sign, to avoid matches on pure symbol input, such as "(!)" or whatever. Diffs (updated) ----- plasma/generic/runners/calculator/calculatorrunner.h 3a031e0 plasma/generic/runners/calculator/calculatorrunner.cpp 8d00449 Diff: https://git.reviewboard.kde.org/r/114746/diff/ Testing ------- Thanks, Christoph Feck
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel