> On Jan. 8, 2014, 7:46 p.m., David Edmundson wrote: > > plasma/qmlpackages/desktop/contents/explorer/WidgetExplorer.qml, line 314 > > <https://git.reviewboard.kde.org/r/114913/diff/1/?file=233500#file233500line314> > > > > Ooops, this is wrong. > > I need to add an orientation check. > > Marco Martin wrote: > are we sure we still wantto support the orientation? code would be much > simpler if the horizontal case just goes
I'd like to see that horizontal mode code gone. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114913/#review47081 ----------------------------------------------------------- On Jan. 8, 2014, 7:49 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114913/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 7:49 p.m.) > > > Review request for Plasma. > > > Repository: kde-workspace > > > Description > ------- > > Adjust all WidgetExplorer animations to be a bit simpler. > > Fixes a bug where items would reappear slightly when exiting the view > Also tidies up objects moving around when items are inserted. > > Makes everything look faster too. > > > Diffs > ----- > > plasma/qmlpackages/desktop/contents/explorer/AppletDelegate.qml 4bec01a > plasma/qmlpackages/desktop/contents/explorer/WidgetExplorer.qml 4b32bab > > Diff: https://git.reviewboard.kde.org/r/114913/diff/ > > > Testing > ------- > > Ran in qmlscene --slow-animations adjusting things for about an hour :) > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel