> On Jan. 30, 2014, 9:38 a.m., Marco Martin wrote: > > I don't think it's the right way.. > > thinking about it, that's true for panels as well, (even tough is already > > forced by extended structs, but is not a given since the other panel modes > > still have to come back) > > > > what it suggests me is that this should depend from the visualparent window > > type, but not from an ad-hoc api for sure
So to confirm: I keep the logic, but I drop having an explicit property. Instead I determine which mode to do based on the type of item->window() ? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/#review48588 ----------------------------------------------------------- On Jan. 29, 2014, 10:51 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115393/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 10:51 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > > For the WidgetExplorer we want to show the tooltips to the right of the > scrollbar in the view, not to the right of the delegate the tooltip is > for. > This patch adds a boolean flag which shifts it to the nearest point to > the visualParent which is outside the visualParent's window - in this > case outside the scrollbar. > > I have also introduced a manual test for Dialog Positioning, and > includied some fixes in the original logic. > > > Diffs > ----- > > src/declarativeimports/core/dialog.cpp 0248596 > src/declarativeimports/core/tests/manual/dialog_positioning.qml > PRE-CREATION > src/declarativeimports/core/dialog.h dc2b688 > > Diff: https://git.reviewboard.kde.org/r/115393/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
