> On Jan. 30, 2014, 2:59 p.m., David Edmundson wrote: > > This patch doesn't match the review description at all. It just prints the > > error messages.
the idea of the patch was to pass the errors with "m_qmlObject->rootObject()->setProperty("warnings", warn);" because we needed it for plasmoidviewer. But with the qC* methods there is a better way of doing it. qInstallMessageHandler and the qC* methods will do the job. So I will discard this review - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/#review48630 ----------------------------------------------------------- On Oct. 14, 2013, 7:51 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113236/ > ----------------------------------------------------------- > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch takes the QQmlErrors of QQmlEngine::errors signal and passes them > to a property of QmlObject, so the errors become accessible from QML. > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/appletinterface.cpp 214a4b1 > > Diff: https://git.reviewboard.kde.org/r/113236/diff/ > > > Testing > ------- > > I have create a `property string warnings` inside in a containment > and I was able to print the warnings with > > `onWarningsChanged: console.log(warnings)` > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel