> On Feb. 3, 2014, 9:32 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/digital-clock/clock.cpp, line 714 > > <https://git.reviewboard.kde.org/r/115431/diff/3/?file=241362#file241362line714> > > > > This seems overly complex to me. In other such places, we happily use > > "M". > > > > Do you still see the issue if you just use "M" here?
I'm not quite understood. Do you mean that we should change everything to M? For example, "06:00 PM Saturday" to "MMMMMMMMMMMMMMMMM"? I think that will be overly wide. - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review48795 ----------------------------------------------------------- On Feb. 2, 2014, 12:31 p.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115431/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2014, 12:31 p.m.) > > > Review request for Plasma. > > > Bugs: 228902 > http://bugs.kde.org/show_bug.cgi?id=228902 > > > Repository: kde-workspace > > > Description > ------- > > For bug, see > https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and > https://bugs.kde.org/show_bug.cgi?id=228902 > > The problem is that in original code, it always uses 23:59 to calculate the > width of the text. However, in some font, AM is wider than PM, and 0 is > wider than 2 and 5. That causes some fonts been cropped. > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.cpp f26e328 > > Diff: https://git.reviewboard.kde.org/r/115431/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel