> On Feb. 3, 2014, 5:07 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/dialog.cpp, line 258 > > <https://git.reviewboard.kde.org/r/115448/diff/1/?file=241628#file241628line258> > > > > why do you cast to int? That will break with > > https://git.reviewboard.kde.org/r/115442/
well I didn't know about that review. It looks sensible. I need it ATM, as implicitly casting a long to an int will give a warning otherwise. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115448/#review48842 ----------------------------------------------------------- On Feb. 3, 2014, 3:47 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115448/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 3:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Fix multiscreen popup positioning > > > Diffs > ----- > > src/declarativeimports/core/dialog.h fd6b0d0 > src/declarativeimports/core/dialog.cpp 8ce848f > > Diff: https://git.reviewboard.kde.org/r/115448/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
