----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/#review52087 -----------------------------------------------------------
Ship it! Makes sense. src/shell/panelview.cpp <https://git.reviewboard.kde.org/r/116614/#comment36984> don't commit commented out code - David Edmundson On March 5, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116614/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 1:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > There are 2 (quite separate) changes: > * Never use the window size to figure out the thickness: This is bad because > sometimes this will get called before the move hasn't been effective, which > results in full-screen struts. Use the thickness method from KConfig instead. > * Don't call setPosition and resize, but do it all at once in a setGeometry > call. It simplifies the life of the QPA and WM, also it's quite faster as we > reduce the calls to the WM by half (both setPosition and resize are > syntax-sugar for setGeometry). > > > Diffs > ----- > > src/shell/panelview.cpp a09a61a > > Diff: https://git.reviewboard.kde.org/r/116614/diff/ > > > Testing > ------- > > Played with it, KWin didn't decide to throw my windows to the other screen. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
