----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52206 -----------------------------------------------------------
Good work! Neat and best solution as of whatever we came across till now! From my side, it should go ahead. Please wait for some time in case any one has any concern. shells/newshell/package/contents/ui/mediacenter.qml <https://git.reviewboard.kde.org/r/116620/#comment36996> Please follow, if-else code format as: if (condition) { // statement } else { // statement } - Sinny Kumari On March 5, 2014, 5:46 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116620/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 5:46 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Playlist was not reachable from home screen as reported in Bug 322820 : > https://bugs.kde.org/show_bug.cgi?id=322820 > > Default behavior of pmc when user clicks on empty area is to show the media > player instance when some media is playing and if not then it does nothing. > This patch will show the media controller when empty area is clicked and > there is no media playing, so that user can now access playlists from > there.Clicking again will hide the controller. > > If we want to show the playlist page directly by clicking the empty area (i.e > no media controller shown) then the 154th line can be changed to : > pmcPageStack.pushAndFocus(getPlaylist()); > > > Diffs > ----- > > shells/newshell/package/contents/ui/mediacenter.qml 49ea403 > > Diff: https://git.reviewboard.kde.org/r/116620/diff/ > > > Testing > ------- > > 1.On welcome screen, (when no media is playing) clicked on empty area and the > media controller is showing and it goes into hiding by clicking again in > empty area. > 2.Left the media controller visible on welcome screen and started some media > and then again went back to welcome screen, media controller is not visible > now. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
