> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
>     They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
>     
>     This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
>     Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
>     
>     That would at least keep the default consistent.
>     Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
>     
>     Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, <fill in any gtk app>
> 
> Martin Gräßlin wrote:
>     @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.

@Mark: Nobody assures Chrome will be using "Sans Serif" either, this patch 
doesn't make a difference in this regard...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
-----------------------------------------------------------


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> -------
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to